Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add campaign module and banners #2352

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the campaign module, the banners and the code to consume the campaign data and use it.

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marketplace ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 8:09pm

@coveralls
Copy link

coveralls commented Jan 21, 2025

Coverage Status

coverage: 66.226% (-0.006%) from 66.232%
when pulling 39c6ef9 on feat/add-campaign-module-and-banners
into a6b721b on master.

@@ -34,14 +33,16 @@ const Navigation = (props: Props) => {
status: AssetStatusFilter.ON_SALE
}

console.log('Campaign tab', { campaignTab })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('Campaign tab', { campaignTab })

onFetchEventContracts(CAMPAIGN_TAG, ADDITIONAL_CAMPAIGN_BROWSE_TAGS)
}, [onFetchEventContracts])
if (campaignTag) {
console.log('Fetching event contracts')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('Fetching event contracts')

@LautaroPetaccio LautaroPetaccio merged commit 211a5b1 into master Jan 21, 2025
9 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-campaign-module-and-banners branch January 21, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants